bump app version [skip ci] - #1180
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Helm chart metadata for the helm/library/cortex application chart to point to a newer Cortex application SHA, keeping the deployment artifact aligned with the bumped underlying Cortex revision.
Changes:
- Bumped
appVersionin the Cortex Helm chart fromsha-91df27a0tosha-90034161.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1ff2b0d to
a8392ee
Compare
a8392ee to
3052760
Compare
| version: 0.4.0 | ||
| appVersion: "sha-91df27a0" | ||
| appVersion: "sha-ccd47209" |
3052760 to
4fcaa6f
Compare
4fcaa6f to
7152c14
Compare
7152c14 to
d8e270c
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The modified Chart.yaml files are missing the SPDX license header that is consistently present in the repository’s other Helm charts.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
| @@ -3,6 +3,6 @@ name: cortex-shim | |||
| description: A Helm chart to distribute cortex shims. | |||
| type: application | |||
| version: 0.1.15 | |||
| appVersion: "sha-17e0a4fe" | |||
| appVersion: "sha-46aeea6b" | |||
| @@ -3,6 +3,6 @@ name: cortex | |||
| description: A Helm chart to distribute cortex. | |||
| type: application | |||
| version: 0.4.0 | |||
| appVersion: "sha-91df27a0" | |||
| appVersion: "sha-da763be7" | |||
54188b3 to
ba55f66
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The chart version fields were not bumped alongside appVersion, which can prevent Helm consumers from detecting/pulling the update.
Review details
Suppressed comments (2)
helm/library/cortex/Chart.yaml:6
- Chart
versionis unchanged whileappVersionis updated. Helm usesversion(Chart.yaml) to detect chart updates; leaving it the same can prevent consumers from picking up the new app version via dependency updates/registry releases.
version: 0.4.0
appVersion: "sha-1a3f701f"
helm/library/cortex-shim/Chart.yaml:6
- Chart
versionis unchanged whileappVersionis updated. Helm usesversion(Chart.yaml) to detect chart updates; leaving it the same can prevent consumers from picking up the new app version via dependency updates/registry releases.
version: 0.1.16
appVersion: "sha-261b4905"
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
ba55f66 to
c5edc3c
Compare
c5edc3c to
670d25e
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The modified Chart.yaml files are missing the repository license header and the chart versions are not bumped alongside the appVersion change, which can break dependency consumption in bundle charts.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
helm/library/cortex-shim/Chart.yaml:6
- The chart's appVersion was updated, but the chart version was not bumped. Since bundle charts pin this dependency by chart version (e.g., helm/bundles/cortex-placement-shim/Chart.yaml:14 uses version 0.1.16), keeping version unchanged can prevent consumers from picking up the new appVersion unless the OCI tag is overwritten. Bump the chart version and update dependent bundle dependency versions accordingly.
version: 0.1.16
appVersion: "sha-0cf9e776"
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Lite
| version: 0.4.0 | ||
| appVersion: "sha-91df27a0" | ||
| appVersion: "sha-261b4905" |
| @@ -3,6 +3,6 @@ name: cortex-shim | |||
| description: A Helm chart to distribute cortex shims. | |||
| type: application | |||
| version: 0.1.16 | |||
| appVersion: "sha-b577e306" | |||
| appVersion: "sha-261b4905" | |||
| @@ -3,6 +3,6 @@ name: cortex | |||
| description: A Helm chart to distribute cortex. | |||
| type: application | |||
| version: 0.4.0 | |||
| appVersion: "sha-91df27a0" | |||
| appVersion: "sha-261b4905" | |||
670d25e to
e392e33
Compare
e392e33 to
53b3874
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The modified Chart.yaml files are missing the repo-standard SPDX license header, which should be added for consistency and license compliance.
Review details
Suppressed comments (2)
helm/library/cortex/Chart.yaml:6
- This Chart.yaml is missing the standard SPDX license header that other Helm charts in this repo include (e.g., helm/library/cortex-postgres/Chart.yaml:1-2, helm/bundles/cortex-nova/Chart.yaml:1-2). Since this file is being updated, please add the header for consistency and license compliance.
appVersion: "sha-0cf9e776"
helm/library/cortex-shim/Chart.yaml:6
- This Chart.yaml is missing the standard SPDX license header that other Helm charts in this repo include (e.g., helm/library/cortex-postgres/Chart.yaml:1-2, helm/bundles/cortex-nova/Chart.yaml:1-2). Since this file is being updated, please add the header for consistency and license compliance.
appVersion: "sha-cd38777a"
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
53b3874 to
0b66d54
Compare
bumped cortex: sha-cd38777a -> sha-2d3af7e9 noop cortex-shim (sha-cd38777a) noop cortex-postgres (sha-cf70e178) Signed-off-by: juliusclausnitzer <65490082+juliusclausnitzer@users.noreply.github.com>
0b66d54 to
44c159d
Compare
bump app version [skip ci]